Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readibility of sync service #2370

Open
AurelienFT opened this issue Oct 18, 2024 · 0 comments
Open

Improve readibility of sync service #2370

AurelienFT opened this issue Oct 18, 2024 · 0 comments
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@AurelienFT
Copy link
Contributor

Description

The way the sync service manage the boolean sent to the service runner is very deeply nested and make the understanding of the global module behavior pretty complex.
More over the function, get_block_stream contains way too much logic it can be improved and splitted. (#2361 (comment)) (#2361 (comment))
@AurelienFT AurelienFT added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Oct 18, 2024
@AurelienFT AurelienFT mentioned this issue Oct 18, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AurelienFT