Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMM: remove SCRIPT_GAS_LIMIT in favour of .estimate_transaction_cost() in tests #667

Open
K1-R1 opened this issue May 15, 2023 · 2 comments
Open

AMM: remove SCRIPT_GAS_LIMIT in favour of .estimate_transaction_cost() in tests #667

K1-R1 opened this issue May 15, 2023 · 2 comments
Assignees
@calldelegation
Labels
App: AMM Label used to filter for the app issue Awaiting SDK feature(s) SDK does not support desired functionality, yet Good First Issue Good for newcomers Improvement Enhancing a feature that already exists

Comments

@K1-R1
Copy link
Member

K1-R1 commented May 15, 2023

Motivation

In project/test-utils/src/interface.rs:

pub const SCRIPT_GAS_LIMIT: u64 = 100_000_000; // TODO: hardcoded until scripts have gas estimation
@K1-R1 K1-R1 added Good First Issue Good for newcomers Improvement Enhancing a feature that already exists App: AMM Label used to filter for the app issue labels May 15, 2023
@calldelegation calldelegation self-assigned this May 17, 2023
@calldelegation
Copy link

Waiting for FuelLabs/fuels-rs#973 to be merged and to be included in the next fuels-rs release

@calldelegation calldelegation added the Awaiting SDK feature(s) SDK does not support desired functionality, yet label May 18, 2023
@calldelegation
Copy link

related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calldelegation calldelegation

Labels
App: AMM Label used to filter for the app issue Awaiting SDK feature(s) SDK does not support desired functionality, yet Good First Issue Good for newcomers Improvement Enhancing a feature that already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@K1-R1 @calldelegation