Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MODEM code #433

Open
tschak909 opened this issue Feb 9, 2021 · 2 comments
Open

Refactor MODEM code #433

tschak909 opened this issue Feb 9, 2021 · 2 comments
Labels
enhancement New feature or request refactor Issues relating to code refactoring.

Comments

@tschak909
Copy link
Collaborator

The current WiFi MODEM code lives monolithically inside sio/modem.cpp.

This should be re-factored outward into its own library under lib/ so it can be used by other peripheral buses (and by CP/M)

The idea here is to:

  • Seperate out the core modem code
  • Call an initialization function with a pointer to the desired UART.
  • Replace explicit calls to fnUARTSIO to use this pointer.
  • Make lib/sio/modem.cpp use the now factored library.
@tschak909 tschak909 added enhancement New feature or request refactor Issues relating to code refactoring. labels Feb 9, 2021
@brad-colbert
Copy link

brad-colbert commented Apr 15, 2021 •
edited
Loading

Is this simply a "move and create an interface" job?

@tschak909
Copy link
Collaborator Author

yeah.

@markjfisher markjfisher mentioned this issue Nov 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor Issues relating to code refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tschak909 @brad-colbert