Manual build trigger button (#45) resolved #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpsonntag
requested changes
Jun 24, 2022
There was a problem hiding this comment.
Using the /pubvalidate route does not work with private repositories.
Further the public validation does not link the latest validation and therefore a triggered validation run would not show up on the results page which is what the issue tries to solve.
Most probably a new route is required that checks the permissions internally, runs the required validation and links the results appropriately.
| <td class="name four wide"><form action="/pubvalidate" method="post"> | ||
| <input type="hidden" name="validator" value="{{$hookname}}" /> | ||
| <input type="hidden" name="repopath" value="{{$.FullName}}" /> | ||
| <input type="submit" value="Validate once" /> |
There was a problem hiding this comment.
Please change text to "Run validation"
| @@ -84,6 +84,11 @@ const RepoPage = ` | |||
| {{range $hookname, $hook := .Hooks}} | |||
| <tr> | |||
| <td class="name text bold four wide"><a href="">{{$hookname | ToUpper}}</a></td> | |||
| <td class="name four wide"><form action="/pubvalidate" method="post"> | |||
There was a problem hiding this comment.
Using the /pubvalidate route does not work with private repositories.
Closes G-Node#45 The button is added directly to the template
Pull Request Test Coverage Report for Build 2567213961
💛 - Coveralls |
|
This PR is closed for now due to the fact that private repositories are in this state hard to validate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
The button is added directly to the template