Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unequippable" rename #48

Open
DinizSa opened this issue Apr 3, 2023 · 1 comment
Open

"Unequippable" rename #48

DinizSa opened this issue Apr 3, 2023 · 1 comment

Comments

@DinizSa
Copy link

DinizSa commented Apr 3, 2023

From chatgpt3 the definition of “Unequippable” is: "something cannot be equipped or used for its intended purpose".
However in the contract the variable "unequippable" is used to determine if an item can be unequipped, which might lead to confusion.

I would like to suggest a rename of this variable. Maybe "persistent" or “permanent” would be a better fit.

@ogarciarevett
Copy link
Contributor

Renaming the function facets, means that anyone with the new version, will have an Error in their game/system that's using the inventory.

As breaking change I'll put this over our list for the next major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants