Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create metadata descirption for models (FMU's) #125

Open
heuerfin opened this issue Nov 26, 2024 · 5 comments · May be fixed by #127
Open

Create metadata descirption for models (FMU's) #125

heuerfin opened this issue Nov 26, 2024 · 5 comments · May be fixed by #127
Assignees
Labels
enhancement New feature or request

Comments

@heuerfin
Copy link
Contributor

heuerfin commented Nov 26, 2024

As discussed in todays meeting, we need a ontology and shacl for models. The attributes should follow: https://github.com/openMSL/sl-1-1-reflection-based-radar-object-model/blob/main/sl-1-1-reflection-based-radar-object-model.srmd according to https://gitlab.setlevel.de/open/processes_and_traceability/traceability_data/-/blob/main/SETLevel_SRMD_and_classifications_for_metadata.pdf?ref_type=heads.

@heuerfin heuerfin added the enhancement New feature or request label Nov 26, 2024
@heuerfin
Copy link
Contributor Author

I've created the basics for the description of FMU's according to setlevel attributes branch/125-create-metadata-descirption-for-models-fmus. Overview of the variables: VARIABLES.md.

@raue @localhorst87 @PeLe987 Please look at the categorization into Format, Content, Quantity, Quality , and DataSource (these categories are predefined by the other ontologies). I've categorized them with my best guess. However, currently I think we don't need Quantity and probably not DataSource (move attribute model.specification to Content).
Do you have any opinions about that? Otherwise I will create a pull request.

@raue
Copy link

raue commented Nov 26, 2024

Couldn't find 'Quantity' in VARIABLES.md. Eventhough some quantities (e.g. number of detected objects - if this is meant) wouldn't really hurt to have. But for that information about the object type (e.g. VRU) should also be given. For demo purposes I'd skip quantity, if it causes too much efforts,
'DataSource' seems to be desirable for me, since it provides the link to the full blown model description (i.e. specification).
Again, due to the remaining time, we should keep it small in case of any doubts.
BTW: warum nutzen wir hier eigentlich Englisch?

@heuerfin
Copy link
Contributor Author

heuerfin commented Nov 27, 2024

We use english since this is a public repository and everyone can follow the discussions ;) (at least this was my understanding).
Regarding Quantity, yes for the first attempt I did not sort any of the variables into this category. However, I can simply add some. Is the number of detected objects a common attribute of a simulation model (sensor, traffic participant, ...)? I would think this is more an attribute of the execution and the resulting OSITrace? It is currently modeled in a OSITrace file. Maybe the number of parameters could be an attribute for Quantity regarding a simulation model?
Regarding DataSource, if it is fine to map the specification to DataSource, we should keep it. I just thought maybe it is better to be located in Content. However, with DataSource it should be fine then.

@raue
Copy link

raue commented Nov 27, 2024

ok, I considered this as more private, but we can stick to englisch ...
yes, I agree. My first thoughts were moving more in the direction of sensor data when it comes to quantity. But maybe somenthing, which goes into that direction from the model point of view could be the max. number of detections and objects a model can provide (this indeed are features from the real sensor ARS548 (max. detections = 800, max. objects = 50)).

@heuerfin
Copy link
Contributor Author

heuerfin commented Dec 2, 2024

Ok. I've added both attributes in simulation-model_shacl.ttl#L199 .Also available in Variables.md and the example. Is this fine for you? Then I create a pull request.

@heuerfin heuerfin linked a pull request Dec 3, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants