Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗ [Notification] New notification feature #10220

Closed
2 tasks done
Tracked by #10221
gobyrne opened this issue Apr 30, 2024 · 6 comments · Fixed by #10570
Closed
2 tasks done
Tracked by #10221

❗ [Notification] New notification feature #10220

gobyrne opened this issue Apr 30, 2024 · 6 comments · Fixed by #10570
Assignees
Labels
deployment Requires a change during deployment feature New feature or request.
Milestone

Comments

@gobyrne
Copy link
Member

gobyrne commented Apr 30, 2024

✨ Purpose

New feature announcement:
This is to notify people that notifications are live!

❗ Trigger

All users should get this notification when the notification feature flag is turned off (or on?) (migration?)

This is a one-time notification. Which is something we haven't done before.

👀 Audience

All users - this is a System notification

🌎 Copy (localized)

Email templates (English and French)

Note: Delete the quoted section below from the email template.

Subject:
GC Digital Talent notifications system is now online!

Body:
Hey {{user.firstname}},

You are receiving this email because you registered for GC Digital Talent.

Our new notification system is now live!

You’ll now be able to sign up to be notified of things like new opportunities, status updates on your submitted applications, and closing date reminders on applications you've started.

{View your profile preferences {hyperlink: notification_settings.URL}} to choose what messages you receive in the future.

GC Digital Talent team

{GC Digital Talent {hyperlink:Talent.canada.ca}} is a recruitment platform for digital jobs in the Government of Canada.


If you no longer want to receive these updates, you can {{unsubscribe from notifications}}.

This is an automated message, so please do not reply. If you need to provide feedback or report a problem, contact our help desk

In-app string (English and French)

Our new notification system is now live!
View your profile preferences to choose what messages you receive in the future.

Link

This should link to the account settings - notifications settings from #9556

✅ Acceptance Criteria

  • Infrastructure set up for one-time notifications
  • Notification class exists in Laravel
  • Notification is triggered by appropriate event and send to appropriate users (including NOT any users who are ignoring this notification's Notification Family)
  • Notification type added to schema
  • Notification type (system notification) rendered appropriately on frontend
  • Tests?

🛑 Blockers

Issues which must be completed before this one.

Blocked By

  1. 0 of 1
    deployment feature
    petertgiles
  2. deployment
@gobyrne gobyrne added feature New feature or request. blocked: copy Blocked by missing copy or translations labels Apr 30, 2024
@gobyrne gobyrne added this to the Notifications milestone Apr 30, 2024
@petertgiles
Copy link
Contributor

Putting in all the infrastructure for a one-off notification like this is going to take significant effort and leave behind a lot of cruft. One option would be to create a generic "announcement" notification with message and link properties that could be reused whenever a new announcement needs to be made. Another option would be to use the sidewide banner that already exists.

@mbasadi
Copy link

mbasadi commented May 4, 2024

Putting in all the infrastructure for a one-off notification like this is going to take significant effort and leave behind a lot of cruft. One option would be to create a generic "announcement" notification with message and link properties that could be reused whenever a new announcement needs to be made. Another option would be to use the sidewide banner that already exists.

Great point,
We at notificationAPI have provided a generic solution for this issue. It comes with exciting features such as user preferences center, where a user can configure their preferences, and all the logic is handled by us out of the box. Plus, you will get the log of what has happened to the notification from the moment we receive the request until your user receives it. Not only these, but it also comes with other interesting features such as Scheduling, Batch and Digest, and Deduplication.
Definitely take a look at it before investing a lot of time in building it.

@gobyrne
Copy link
Member Author

gobyrne commented May 10, 2024

Putting in all the infrastructure for a one-off notification like this is going to take significant effort and leave behind a lot of cruft. One option would be to create a generic "announcement" notification with message and link properties that could be reused whenever a new announcement needs to be made. Another option would be to use the sidewide banner that already exists.

Yeah, likely we will want this for major feature releases going forward. Not just this one time.

Copy link

Status: Ready to merge ✔️

Issues blocking this PR:


This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress.

@gobyrne
Copy link
Member Author

gobyrne commented May 24, 2024

@marc-donofrio is sending to translation

@petertgiles petertgiles added the review in refinement Ready to be looked at and pulled into "ready to dev" label May 24, 2024
@gobyrne gobyrne added review in refinement Ready to be looked at and pulled into "ready to dev" and removed blocked: copy Blocked by missing copy or translations review in refinement Ready to be looked at and pulled into "ready to dev" labels May 24, 2024
@petertgiles petertgiles removed the review in refinement Ready to be looked at and pulled into "ready to dev" label May 27, 2024
@petertgiles petertgiles self-assigned this May 30, 2024
@petertgiles petertgiles added deployment Requires a change during deployment blocked: copy Blocked by missing copy or translations labels May 31, 2024
@marc-donofrio
Copy link

marc-donofrio commented Jun 12, 2024

Final bilingual copy

EN:
In app notification: 
Our new notification system is now live!  
View your profile preferences to choose what messages you receive in the future. 
 (hyperlinked to notifications settings)

EN Email Subject: 
 
GC Digital Talent notifications system is now online! 
 
Notification copy:  

Hey (first.lastname),

You are receiving this email because you registered for GC Digital Talent.  

Our new notification system is now live!  

You’ll now be able to sign up to be notified of things like new opportunities, status updates on your submitted applications, and closing date reminders on applications you’ve started. 

(View your profile preferences (hyperlinked to notifications settings)) to choose what messages you receive in the future. 
 
GC Digital Talent team 
 
 
((GC Digital Talent hyperlink: talent.canada.ca)) is a recruitment platform for digital jobs in the Government of Canada. 
--- 
This is an automated message, so please do not reply. If you need to provide feedback or report a problem, 
(contact our help desk(hyperlink to Contact us page)).

FR:

In app notification: 
Notre nouveau mode de notification est en ligne!  
Veuillez mettre à jour vos préférences dans votre profil afin de recevoir les messages de votre choix.  (hyperlinked to notifications settings)

EN Email Subject: 
 
Le mode de notification de la plateforme Talents numériques du GC est en ligne! 
 
Notification copy:  

Bonjour {prénom et nom},

Nous vous faisons parvenir ce courriel en raison de votre inscription à la plateforme Talents numériques du GC.  

Notre nouveau mode de notification est en ligne!  

Désormais, vous pourrez recevoir des alertes, dont celles qui touchent les nouvelles perspectives d’emploi, l’état d’avancement de vos demandes d’emploi et la date limite de vos candidatures en cours. 

(Veuillez mettre à jour vos préférences (hyperlinked to notifications settings)) dans votre profil afin de recevoir les messages de votre choix. 
 
L’équipe des Talents numériques du GC 
 
 
(La plateforme Talents numériques du GC(hyperlinked to notifications settings)) sert à pourvoir les postes du secteur numérique au gouvernement du Canada. 
--- 
Ce message est automatique. Veuillez ne pas y répondre. Pour nous faire part de vos commentaires ou signaler un problème, veuillez communiquer avec notre (bureau de soutien(hyperlink to Contact us page)).

@petertgiles petertgiles removed the blocked: copy Blocked by missing copy or translations label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Requires a change during deployment feature New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants