Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VerticalDimSpec #3106

Open
tclune opened this issue Oct 18, 2024 · 0 comments
Open

Move VerticalDimSpec #3106

tclune opened this issue Oct 18, 2024 · 0 comments
Labels
📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Oct 18, 2024

Routines in ./field_utils need access but VerticalDimSpec lives in generic3g. Module should be moved - probably to field_utils. Or maybe into ./vertical which should then be moved out of generic3g.

Currently important strings are instead duplicated across modules.

Another solution could be to move the named constants into ./shared.
@tclune tclune added 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclune