Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.py should not import MepoState (from state.py) #313

Closed
pchakraborty opened this issue Aug 19, 2024 · 1 comment
Closed

git.py should not import MepoState (from state.py) #313

pchakraborty opened this issue Aug 19, 2024 · 1 comment
Assignees

Comments

@pchakraborty
Copy link
Collaborator

Currently GitRepository uses MepoState to get the full local path of the fixture, in order to construct the full local path of a sub-component, which are specified in the registry in relative form. Maybe there is a better way to get the full local path of the fixture that doesn't require dependence on MepoState.

One consequence of git.py's dependence on MepoState is that we need two separate copies of get_current_remote_url - one in git.py and the other in component.py, to avoid circular dependency. Once #312 is implemented, the need for get_current_remote_url goes away, but it will still be good to find a way to remove this dependence.

@pchakraborty pchakraborty self-assigned this Aug 19, 2024
@pchakraborty
Copy link
Collaborator Author

Resolved in #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant