Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add a test to check that diagram JSON is valid #213

Open
duncandewhurst opened this issue Aug 28, 2023 · 1 comment
Open

Tests: Add a test to check that diagram JSON is valid #213

duncandewhurst opened this issue Aug 28, 2023 · 1 comment

Comments

@duncandewhurst
Copy link
Contributor

#212 adds diagrams which are generated from snippets of RDLS JSON data.

We should add a test to check that the JSON snippets are valid RDLS data and do not contain additional fields.

To do that, the test will need to preprocess the schema in order to:

  • Make all fields optional
  • Disallow additional properties everywhere
  • Allow empty strings, objects and arrays
@duncandewhurst
Copy link
Contributor Author

Following the changes in f3a9c30, we'll also need to relax type validation for the JSON snippets in order to allow empty strings in place of objects and arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant