-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
50 oqapiattribute completeness allow definition of custom attributes #53
Open
mcauer
wants to merge
27
commits into
main
Choose a base branch
from
50-oqapiattribute-completeness-allow-definition-of-custom-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
50 oqapiattribute completeness allow definition of custom attributes #53
mcauer
wants to merge
27
commits into
main
from
50-oqapiattribute-completeness-allow-definition-of-custom-attributes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ui dropdown functionality
… by moving leaflet map outside of angular change detection zone
…he oqt-api-metadata-provider.service.ts
Indicators, like attribute-completeness, can have aditional params, like attributes or attributeTitle and attributeFilter. These are handled generically now if they appear in the form values with the naming convention indicator-name--param-name. The second part will be associated to the indicator request body as camel-cased parameter, e.g. paramName
…bute-completeness-attribute component, so that in the custom edit filter dialog the topic filter and its aggregation types can be displayed instead of indicatorKey and indicatorName hand over the complete indicator object
…ned attributes for the attribute-completeness indicator
normal label elements have flow content, so the icon will be at the end of the text. In case of long text now the text can line-break but the close icon will stay at the top right of the element
as we do not build or customize the styles, we can get rid of the source code and only keep the built version in the dist folder
7 tasks
7 tasks
7 tasks
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50