Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50 oqapiattribute completeness allow definition of custom attributes #53

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

mcauer
Copy link
Member

@mcauer mcauer commented Dec 6, 2024

closes #50

… by moving leaflet map outside of angular change detection zone
Indicators, like attribute-completeness, can have aditional params, like attributes or attributeTitle and attributeFilter. These are handled generically now if they appear in the form values with the naming convention indicator-name--param-name. The second part will be associated to the indicator request body as camel-cased parameter, e.g. paramName
…bute-completeness-attribute component, so that in the custom edit filter dialog the topic filter and its aggregation types can be displayed

instead of indicatorKey and indicatorName hand over the complete indicator object
…ned attributes for the attribute-completeness indicator
normal label elements have flow content, so the icon will be at the end of the text. In case of long text now the text can line-break but the close icon will stay at the top right of the element
as we do not build or customize the styles, we can get rid of the source code and only keep the built version in the dist folder
@mcauer mcauer requested a review from ElJocho December 6, 2024 22:22
@mcauer mcauer linked an issue Dec 6, 2024 that may be closed by this pull request
7 tasks
@mcauer mcauer self-assigned this Dec 6, 2024
@mcauer mcauer linked an issue Dec 6, 2024 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oqapi(attribute-completeness): Allow definition of custom attributes
1 participant