Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mapping from Geocoded to original addresses #162

Open
rivettp opened this issue Oct 14, 2019 · 2 comments
Open

Improve mapping from Geocoded to original addresses #162

rivettp opened this issue Oct 14, 2019 · 2 comments
Assignees
@rivettp @tahoeblue

Comments

@rivettp
Copy link
Contributor

rivettp commented Oct 14, 2019

At the moment this uses matching on the first line of the addresses, which generally does not work when it starts "C/O". It should be possible to apply some heuristics to make this more complete.
BTW the original XML does not have this mapping either - just a list of Geocoded addresses attached to the LEI Record indepedendently of the other addresses.
@rivettp rivettp self-assigned this Oct 14, 2019
@rivettp rivettp mentioned this issue Dec 19, 2019
Merged
@rivettp rivettp added the in pr There's a PR that addresses this label Jan 16, 2020
@rivettp
Copy link
Contributor Author

rivettp commented Jan 16, 2020

Pull request just made reduces the number of non-matches from 218k to 16k. There's more that could be done e.g. by comparing postal codes.

@rivettp rivettp removed the in pr There's a PR that addresses this label Jan 28, 2020
@rivettp
Copy link
Contributor Author

rivettp commented Jan 28, 2020

Leave this open as a lower priority task to apply further heuristics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rivettp rivettp

@tahoeblue tahoeblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rivettp @tahoeblue