Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki page for Compton Polarimetry is incomplete #1389

Open
VinzenzBildstein opened this issue Mar 19, 2024 · 5 comments
Open

Wiki page for Compton Polarimetry is incomplete #1389

VinzenzBildstein opened this issue Mar 19, 2024 · 5 comments

Comments

@VinzenzBildstein
Copy link
Member

I spent some time going through the wiki pages (mainly to update any old information and mark obsolete information) and noticed that the page about Compton polarimetry (https://github.com/GRIFFINCollaboration/GRSISort/wiki/Compton-Polarimetry) is missing some information, namely all the scripts mentioned in it.

I'm guessing these were created on a local account and never added to the repository (I can't find them mentioned anywhere in the commits or logs). These should either be added (maybe @AdamGarnsworthy knows where they are?) or we should try to either specify what they should be doing (maybe re-create them), or mark the page as obsolete.

@AdamGarnsworthy
Copy link
Member

I will email them to you.

@VinzenzBildstein
Copy link
Member Author

The initial versions (with only minor edits) have been added in #1390 and GRIFFINCollaboration/GRSIData#98.

These initial versions are more for documentation, the plan is to change the LeanComptonMatrices program to a helper, and maybe also streamline the other code a bit more so that users don't have to change the code itself (maybe use TUserSettings to read specific parameter needed).

@VinzenzBildstein
Copy link
Member Author

I will leave this open for now, until I had time to do that change to a helper.

@AdamGarnsworthy
Copy link
Member

Thanks. I agree that stuff should be done. Those versions were quickly hacked by an inexperienced GRSISort person in order to make it work for the specific cases.

@VinzenzBildstein
Copy link
Member Author

Yes. This wasn't meant as criticism of the code, I just wanted to make it clear that these are the initial versions and that they will be updated at some point. Adding them now rather than after I had time to change them was done so that we have some documentation of the original versions vs. the new versions (in case any discrepancies or bugs are found later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants