Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submissions on the Rails App - Challenge Managers #33

Open
36 of 55 tasks
r-bartlett-gsa opened this issue Jul 8, 2024 · 7 comments
Open
36 of 55 tasks

Submissions on the Rails App - Challenge Managers #33

r-bartlett-gsa opened this issue Jul 8, 2024 · 7 comments
Assignees

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Jul 8, 2024

User story

As a challenge manager or evaluator, in order to manager evaluations process efficiently, I would like to be able to access submissions on the same app as Evaluation Forms.

Acceptance Criteria:

  • A user can navigate to a page on the Rails app that lists challenges via the dashboard or utility nav:
    • A challenge manager sees a list of challenges they own, and the list displays:
      • Challenge Name, Phase & Status
      • Number of Submissions
      • Evaluation form name and link
      • Evaluations due date
    • An evaluator sees a list of challenges they have assigned submission to, and the list displays: moved to Submissions on the Rails App - Evaluators #285
      • Challenge Name and Phase
      • Number of assigned submissions
      • Number of remaining submissions to evaluate (in progress and not started)
      • Evaluations due date
      • If the user does not have any submissions assigned to them, a message is displayed indicating so
  • The user can view a list of submission for each challenge:
  • Challenge manager can enter and manage evaluators for the challenge, Enter Evaluators #74
  • When the user clicks on View Submissions on Phoenix app, they are routed to the Submissions list on the Rails app, Submissions on the Phoenix App #171

Development tasks:

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Usability testing: mobile and desktop (Tracy or Marni)
  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Aug 8, 2024

Some button styles, colors and labels may have changed and screenshots below may reflect outdated styles. Please refer to Figma for latest designs.
Misalignment in styles, colors and labels should not affect the completion of development work. There will be additional user stories towards the end of this epic or MVP to bring uniformity to styles and colors.
If significant difference is noticed in features / functionality, please contact Renata.

Challenge Managers, mobile

Image

Challenge Managers, desktop

Image


Evaluators

Image
Image

Evaluators, desktop

Image

@stepchud
Copy link
Contributor

stepchud commented Sep 16, 2024

When the user clicks on View Submissions on Phoenix app, they are routed to the Submissions list on the Rails app.

we're removing all access to submissions in Phoenix then?

Challenge manager can enter and manage evaluators for the challenge, #74

I would remove this AC from this Story as it's unrelated to submissions

@r-bartlett-gsa
Copy link
Member Author

@stepchud

we're removing all access to submissions in Phoenix then?

Yes

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 10/22/24 milestone Oct 9, 2024
@stonefilipczak stonefilipczak removed their assignment Oct 16, 2024
@r-bartlett-gsa r-bartlett-gsa changed the title Submissions on the Rails App Submissions on the Rails App - Challenge Managers Nov 20, 2024
@mhotch24
Copy link

@r-bartlett-gsa From https://challenge-dev.app.cloud.gov/ when I log in as a CM, I can only see pages for Submissions & Evaluations, and Evaluation Forms, Resources. When I click on any of the other cards, it asks me to Accept & Log In. When I do, it logs me out of the original areas I had access to and tells me I do not have access.Image

@mhotch24 mhotch24 added bug Something isn't working and removed Ready to test labels Nov 25, 2024
@r-bartlett-gsa r-bartlett-gsa added Ready to test and removed bug Something isn't working labels Nov 25, 2024
@mhotch24
Copy link

mhotch24 commented Dec 2, 2024

@stepchud A11y testing feedback:

@r-bartlett-gsa
Copy link
Member Author

@mhotch24 Please provide a video recording for the A11y issues you are experiencing for this ticket.

@mhotch24
Copy link

@r-bartlett-gsa A recording is not necessary for this one. This card was from Dec. 2nd A11y testing. Much programming has been done since. In fact, I worked with @stepchud last week to solve for some other table issues and perhaps those helped to resolve these. @stepchud can you confirm?

Here is the only issue still remaining and Stephen can share with Stone how he resolved it.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants