Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control-implementation-status Constraint #1017

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to fix the control-implementation-status by changing the target of the constraint to control-implementation/implemented-requirement/statement/by-component/implementation-status/@state and adjusting the necessary content/test files.

Changes

  • Adjusted target of control-implementation-status to control-implementation/implemented-requirement/statement/by-component/implementation-status/@state.
  • Deleted unnecessary content file ssp-control-implementation-status-VALID.xml.
  • Changed the pass yaml file for this constraint to point to fedramp-ssp-example.oscal.xml.
  • Edited fedramp-ssp-example.oscal.xml and ssp-control-implementation-status-INVALID.xml to align with the above constraint.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 17, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 17, 2024 19:41
@Gabeblis Gabeblis linked an issue Dec 17, 2024 that may be closed by this pull request
15 tasks
Rene2mt
Rene2mt previously approved these changes Dec 18, 2024
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

kyhu65867
kyhu65867 previously approved these changes Dec 19, 2024
@Gabeblis Gabeblis dismissed stale reviews from kyhu65867 and Rene2mt via b848c5b December 23, 2024 15:01
@Gabeblis Gabeblis force-pushed the constraints/issue-1010 branch from a37618f to b848c5b Compare December 23, 2024 15:01
@wandmagic
Copy link
Collaborator

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Controls - SSP by-component assemblies have implementation-status
5 participants