Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSVReader and CSVWriter for all CSV work #1769

Open
terrazoon opened this issue Jul 24, 2024 · 1 comment
Open

Use CSVReader and CSVWriter for all CSV work #1769

terrazoon opened this issue Jul 24, 2024 · 1 comment

Comments

@terrazoon
Copy link
Contributor

terrazoon commented Jul 24, 2024

Right now we are doing custom splits and joins on commas everywhere. Which mostly works, but means that users cannot, for example, send a message with a date field and then format that date to "May 20, 2024". Users should be allowed to use commas if they want, and we should be able to handle, but we don't want to support it with a lot of custom code, so use CSVReader and CSVWriter instead.

NOTE: This will require changes on both the admin and the API side.

@terrazoon
Copy link
Contributor Author

Some draft PRs:

GSA/notifications-api#1191
#1755

@sheevdave sheevdave moved this from 🔜 Backlog (Less than 3 Months) to Issue Backlog (More than 3 Months) in Notify.gov product board Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Issue Backlog (More than 3 Months)
Development

No branches or pull requests

1 participant