Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address discrepancies between visualizations, tables, and other data displays (date/time displays and calculations, etc.) #2171

Open
7 tasks
ccostino opened this issue Dec 4, 2024 · 6 comments

Comments

@ccostino
Copy link
Contributor

ccostino commented Dec 4, 2024

We've noticed a few areas where the visualizations and tables we have on our dashboards are not quite in sync with each other and leading to confusion on our team and with our partners. These are things such as:

  • Which timezone is being used to display message send times?
  • Which messages are being included in the counts? Only succeeded and delivered? Also failed? What about pending?
  • Are the ranges accurate?

We ought to spend some time making sure that the data we're showing is accurate, correct, and labeled properly with relevant units/measurements.

Things that need more correct labeling

UTC/Local/TimeZone data display discrepancy

@ccostino ccostino moved this from 🌱 New to Epics - Next/Scoping in Notify.gov product board Dec 4, 2024
@heyitsmebev
Copy link
Contributor

This is what I've gathered
Screenshot 2024-12-04 at 10 04 33 AM

@ecayer
Copy link

ecayer commented Dec 5, 2024

Thanks for gathering this, @heyitsmebev !

Are we all agreed on matching up the Total Messages count with the Recent Activity chart by including Pending messages on the Recent Activity chart? (@terrazoon's suggestion from https://gsa-tts.slack.com/archives/C0107UC0W1M/p1733325721677589) cc @stvnrlly @jonathanbobel @CathyBeil

Other changes needed:

  • the Recent Activity chart should be in the user's timezone
  • the job status for scheduled jobs should give "Scheduled for" and the scheduled for time (or be removed from the table. My personal preference would be to keep it and make it accurate)

@heyitsmebev
Copy link
Contributor

@ecayer

The "Total Messages" chart displays chargeable units as messages sent. Does "chargeable units" have the same meaning as "delivered messages"?

If we do want to add and display pending messages, we'll also need to add update these endpoints:

get_service_notification_statistics_by_day
"/service/{0}/statistics/{1}/{2}".format(service_id, start_date, days)

get_user_service_notification_statistics_by_day
/service/{0}/statistics/user/{1}/{2}/{3}".format(service_id, user_id, start_date, days),

@CathyBeil
Copy link

Related pages with possibly-related issues:
Activity page shows a "Time Sent"...
Image

...clicking on the Job ID shows a very different time scheduled (which I don't think is accurate, since it's not possible to schedule 1+ month in advance):
Image

@ecayer
Copy link

ecayer commented Dec 5, 2024

Need term definitions & it will need backend work.

@ecayer ecayer moved this from Epics - Next/Scoping to Epics - Now in Notify.gov product board Dec 6, 2024
@heyitsmebev
Copy link
Contributor

heyitsmebev commented Dec 6, 2024

Adding this ticket to this epic: When a user schedules a job, they should see "scheduled" instead of "sent" on the Service Activity page #2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Epics - Now
Development

No branches or pull requests

7 participants