Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more sqlalchemy #1417

Open
wants to merge 113 commits into
base: main
Choose a base branch
from
Open

fix more sqlalchemy #1417

wants to merge 113 commits into from

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Nov 14, 2024

Description

Fix remaining queries affected by the upgrade to sqlalchemy 2.0

NOTE: To find things that need changing the search is grep -ri "query\." ./**/**.py. In order to make search either, occurrences where 'query' was just being used as a variable name were changed to 'querie'.

NOTE: There is one test in notification_dao where I changed the expected result. I think sqlalchemy broke whatever strange thing that test was trying to do. As a matter of good maintenance, I don't think the test is doing the right thing trying to override the behavior of the Pagination object based on a flag.

Security Considerations

N/A

@terrazoon terrazoon marked this pull request as draft November 15, 2024 15:26
@terrazoon terrazoon requested a review from a team December 26, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants