You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When this happens, it causes a very noticeable visual refresh of the toggle switches. If a toggle switch is on, after ngOnChanges it will be replaced with a new switch that defaults to off, which will then animate itself turning on again.
To prevent this, could we go one level more granular in ngOnChanges and test whether there were any changes to each file control in the table, and only remake those that changed or were added?
The text was updated successfully, but these errors were encountered:
sam-upload-v2
component inngOnChanges
is recreating the entire table whenever there is any change to theuploadedFiles
input (https://github.com/GSA/sam-ui-elements/blob/master/src/ui-kit/form-controls/upload-v2/upload-v2.component.ts#L253).When this happens, it causes a very noticeable visual refresh of the toggle switches. If a toggle switch is on, after
ngOnChanges
it will be replaced with a new switch that defaults to off, which will then animate itself turning on again.To prevent this, could we go one level more granular in
ngOnChanges
and test whether there were any changes to each file control in the table, and only remake those that changed or were added?The text was updated successfully, but these errors were encountered: