Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blood Magic book text is messed up #17938

Open
2 of 3 tasks
Shahelion opened this issue Nov 11, 2024 · 10 comments
Open
2 of 3 tasks

Blood Magic book text is messed up #17938

Shahelion opened this issue Nov 11, 2024 · 10 comments
Labels
Bug: Minor Mod: Blood Magic Mod: Forbidden Magic Status: Needs Confirmation Issue requires more investigation/testing/confimation on how it is caused. Type: Not GTNH About a non-GTNH usecase. Can still be relevant for GTNH or can be on an actively supported mod. Type: Visual

Comments

@Shahelion
Copy link

Shahelion commented Nov 11, 2024

Your GTNH Discord Username

No response

Your Pack Version

N/A

Your Server

SP

Java Version

Java 8

Type of Server

None

Your Expectation

Trying to read the blood magic guide book. Something has broken the text, half-shoving it off the page. Every page with text is like this. I updated Forbidden Magic, which supposedly added documentation for its rituals, although I can't find those anywhere either.

The Reality

2024-11-10_17 55 54
2024-11-10_17 58 41

Your Proposal

Remove this strange giant space above every page's text. It isn't in the text of the book, so it must be something else.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Shahelion Shahelion added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 11, 2024
@Shahelion
Copy link
Author

Shahelion commented Nov 11, 2024

Also, I specifically added a missing page to my resources folder, and it's no longer being loaded. The page has no text normally, I previously was able to add the missing localization but now it doesn't work.

2024-11-10_18 02 00

@BegeistertsLab
Copy link

Before further investigation can you please state what version you are using? Also have you checked, whether the forbidden magic bug came with the update and is not a pack issue?

@BegeistertsLab BegeistertsLab added Status: Needs More Info Issue requires more clarification from the author and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 11, 2024
@Shahelion
Copy link
Author

Shahelion commented Nov 11, 2024

Blood Magic 1.6.6
GuideAPI 1.1.0

Book did not previously have this issue in my pack, have confirmed this with others. I reverted the FM update, and it didn't fix it, so it's not that.

Will check with latest CF release of Blood Magic, that was what I had in my last big pack update.

@Shahelion
Copy link
Author

Shahelion commented Nov 11, 2024

Using the CurseForge releases of Blood Magic and GuideAPI, the book looks as it should. It also has the tabs properly laid out on the sides, instead of moved to the middle of the page (maybe that was a design choice, I don't know, but the tabs looked better imo). Ignore the different book name, I had changed it back then.
2024-11-11_07 42 39

2024-11-11_07 42 36

@BegeistertsLab BegeistertsLab added Type: Visual Mod: Blood Magic Mod: Forbidden Magic Status: Ready for Developer Issue ready for a developer to pick up and implement Type: Not GTNH About a non-GTNH usecase. Can still be relevant for GTNH or can be on an actively supported mod. and removed Status: Needs More Info Issue requires more clarification from the author labels Nov 11, 2024
@chochem
Copy link
Member

chochem commented Nov 11, 2024

This is fairly low-priority as we don't use the book in GTNH - the infos would all be somewhat wrong with our customizations.
But anybody is free to PR a fix of course.

@Shahelion
Copy link
Author

Shahelion commented Nov 11, 2024

What does GTNH use for the documentation instead? Even if the recipes are different, the basic information would still be useful, such as how the sigils work, or what the various runes do.

Also, I tried the first GTNH BM version (1.3.3-29) and even then, the book was messed up, so it's been like that from the start. Not 100% sure if this is a BM issue or a GuideAPI issue.

@Ethryan
Copy link
Contributor

Ethryan commented Nov 11, 2024

The pack uses quests in BetterQuesting to convey the relevant information for blood magic progression.

@Shahelion
Copy link
Author

I took a look through the changes made, and couldn't find anything that really stood out to me as affecting the book, so I have no idea what even did this. Something added this weird space above every entry, and removed the tabs from the book's main page, and prevents resource packs from altering the localization.

@Pyromanc3r
Copy link

I saw this bug with incorrect text display when I played BM version from CurseForge.
This problem was due to Guide-API. Guide-API version 1.0.1-29 caused this behaviour (it's marked as beta), while 1.0.1-20 was fine.

@Pyromanc3r
Copy link

I also want to caution you to use the GTNH version of Blood Magic in your modpack. At first glance it will work, but you won't be able to improve your altar. The structure simply won't assemble (at least that's how it used to be about a year ago).

@BegeistertsLab BegeistertsLab added Status: Needs Confirmation Issue requires more investigation/testing/confimation on how it is caused. and removed Status: Ready for Developer Issue ready for a developer to pick up and implement labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Mod: Blood Magic Mod: Forbidden Magic Status: Needs Confirmation Issue requires more investigation/testing/confimation on how it is caused. Type: Not GTNH About a non-GTNH usecase. Can still be relevant for GTNH or can be on an actively supported mod. Type: Visual
Projects
None yet
Development

No branches or pull requests

5 participants