OpDialogue : Fix postExecuteBehaviour handling #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by the switch to native python enums from `IECore.Enum`. This commit also preserves compatibility with the old string values provided by `IECore.Enum`. Note that having the `Ops` refer to `GafferCortexUI.OpDialogue.PostExecuteBehaviour` instead of hard-coded strings is not practical because that would require importing `GafferCortexUI` in the `Op`.
johnhaddon
force-pushed
the
PostExecuteBehaviour
branch
from
d543da5
to
743b9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by the switch to native python enums from
IECore.Enum.This commit also preserves compatibility with the old string values provided by
IECore.Enum.Note that having the
Opsrefer toGafferCortexUI.OpDialogue.PostExecuteBehaviourinstead of hard-coded strings is not practical because that would require importingGafferCortexUIin theOp.Checklist