Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quintic kernel for interpolation in Fourier Space #1265

Open
jecampagne opened this issue Dec 16, 2023 · 0 comments
Open

New quintic kernel for interpolation in Fourier Space #1265

jecampagne opened this issue Dec 16, 2023 · 0 comments
Labels
feature request Request for a new feature in GalSim numerics Involving details of the numerical algorithms for performing some calculation(s)

Comments

@jecampagne
Copy link

jecampagne commented Dec 16, 2023

Hello,
I've discussed with @gbernstein and @rmjarvis about a variation of the present Quintic kernel cooked by Gary & Daniel (@danielgruen) in their 2014 article. I have a github repo where I have sone nbs to reproduce the Figures of their paper (In the repo their is also a note in French to make some communication for local colleagues).

Here is some closeup on the central image and one of the first ghost image to compare Gary & Daniel ("BG") kernel and mine ("JE" standing for Jean-Eric)

image

and the error functions curves

image

Now, I would be glad to make a PR with this new kernel. Let me know how to proceed. Thanks.

For instance:

  1. how is computed/defined "def krange(self)": I have seen code 'galsim/interpolant.py'. But there is also in 'src/interpolant.cpp' some code to define _umax with a factor 1/Pi instead a factor 2.
  2. Does USE_TABLES is activated (should be implemented) in the C++ code
  3. I do not what void Quintic::checkSampler() const is doing.
  4. where in th ePython code self._i.getPositiveFlux() and self._i.getNegativeFlux() are defined, I guess in the C++ ?
  5. I have seen in the C++ code some #ifdef ALT_QUINTIC but I remember that it is not used, right?
  6. for the PR I will create a QuinticBis class (both in Python and C++), is-it Ok or do you prefer another naming?
  7. I have seen test_interpolatedimage.py with a section for Quintic interpolant itself L292... and unitIntegral L388... but I may have missed something. Let me know
rmjarvis added a commit to jecampagne/GalSim that referenced this issue Mar 27, 2024
@rmjarvis rmjarvis added numerics Involving details of the numerical algorithms for performing some calculation(s) feature request Request for a new feature in GalSim labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature in GalSim numerics Involving details of the numerical algorithms for performing some calculation(s)
Projects
None yet
Development

No branches or pull requests

2 participants