Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more valid ECDSA test vectors #104

Open
3 tasks
marsella opened this issue Aug 1, 2024 · 2 comments
Open
3 tasks

Add more valid ECDSA test vectors #104

marsella opened this issue Aug 1, 2024 · 2 comments
Labels
good first issue Good for newcomers improvement Addresses fixes or changes to existing specs Suite-B

Comments

@marsella
Copy link
Contributor

marsella commented Aug 1, 2024

There are a bunch of test vectors for ECDSA in RFC 6979. Some of these are for invalid curve-hash combinations. Decide which of these we'd like to include in the repo, then instantiate the needed versions of ECDSA and implement the test vectors.

This might be blocked on #98, in order to be able to switch out different hash functions easily. The current version fixes it to SHA-256, but that only works with two of our curves (P-224 and P-256).

  • Decide which hash-curve combos to instantiate
  • Add all the 6979 test vectors
  • Do a time-limited search for other test vector sources
@marsella
Copy link
Contributor Author

Here's a permalink to the ECDSA sign tests from the previous version of the implementation.

@marsella
Copy link
Contributor Author

#32 also references some ECDSA test vectors from NIST that are already in Cryptol syntax. Add these too, if appropriate!

@mccleeary-galois mccleeary-galois added enhancement New feature or request good first issue Good for newcomers Suite-B labels Aug 29, 2024
@marsella marsella added improvement Addresses fixes or changes to existing specs and removed enhancement New feature or request labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Addresses fixes or changes to existing specs Suite-B
Projects
None yet
Development

No branches or pull requests

2 participants