Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do {Nonce,}AppExprs need annotations? #246

Open
langston-barrett opened this issue Dec 6, 2023 · 0 comments · May be fixed by #247
Open

Do {Nonce,}AppExprs need annotations? #246

langston-barrett opened this issue Dec 6, 2023 · 0 comments · May be fixed by #247

Comments

@langston-barrett
Copy link
Contributor

This is a follow-up to #244, where we observed that BoundVarExprs already carry Nonces, so there's no need to create Annotation expressions for them. As it turns out, the same is true for {Nonce,}AppExpr:

what4/what4/src/What4/Expr/App.hs

Line 111 in 076f49b

= NonceAppExprCtor { nonceExprId :: {-# UNPACK #-} !(Nonce t tp)

what4/what4/src/What4/Expr/App.hs

Line 125 in 076f49b

= AppExprCtor { appExprId :: {-# UNPACK #-} !(Nonce t tp)

Perhaps we should special-case these in the same way we did BoundVarExpr in #245.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

what4: Don't annotate {Nonce,}AppExprs GaloisInc/what4
1 participant
@langston-barrett