This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Can't Print LNURL QR Code Twice #136
Comments
|
Hello, I'm the maintainer for |
galoybot
pushed a commit
that referenced
this issue
May 16, 2023
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together. Updates `jest` from 29.3.1 to 29.5.0 - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v29.5.0/packages/jest) Updates `@types/jest` from 29.2.4 to 29.5.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-minor - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Testing out the latest PR that was merged with LNURL support and think I ran into an issue with printing QR codes.
OS Used: MacOS Monterrey 12.0.1
Browser Used: Safari 15.1 (17612.2.9.1.20)
Steps to reproduce:
1.) Navigate to /[user]/print
2.) Click blue "Use Web URL" button
3.) Click blue "Print QR code" button
4.) Cancel system print window
5.) Click blue "Use LNURL" button
6.) Click blue "Print QR Code" button
7.) Safari will prompt "This webpage is trying to print. Do you want to print this webpage?", click "Print"
8.) Print preview generates blank
I also tested this with Firefox 94.0.2 on the same OS and didn't encounter this issue. Also tested on iOS 15.1.1 with Safari and didn't encounter this issue, so it seems to be only affecting Safari Desktop.
This appears to be a known issue with the
react-to-printlibrary that this repo is using. See: MatthewHerbst/react-to-print#397 . The posted workaround is kind of ugly, unsure if it would be worth it to implement in this repo.The text was updated successfully, but these errors were encountered: