Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addDesignEvent et al. should produce an error if provided a player instead of a user ID #122

Open
Ozzypig-Gamefam opened this issue Dec 22, 2023 · 0 comments

Comments

@Ozzypig-Gamefam
Copy link

The following call fails silently despite it being incorrect:

GameAnalytics:addDesignEvent(player, {
	eventId = "Buy:Apple",
})

The reason for this is that player should be player.UserId, which is not the way a good chunk of Roblox's API works. Therefore, the function should:

  • Extract the userID from a provided Player object to support this call, and/or
  • Produce an error immediately when called using incorrect arguments, ideally via a runtime type check library like osyris' t library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant