Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow accessing assets with write access without incrementing their version #676

Open
RiscadoA opened this issue Oct 5, 2023 · 0 comments · May be fixed by #727
Open

Allow accessing assets with write access without incrementing their version #676

RiscadoA opened this issue Oct 5, 2023 · 0 comments · May be fixed by #727
Labels
A-Engine B-Assets P-Backlog This issue isn't a priority at all

Comments

@RiscadoA
Copy link
Member

RiscadoA commented Oct 5, 2023

Problem

For the #270 issue, @roby2014 came upon the problem that every write access the version of the asset was being increased, even though it wasn't being modified.
This is a nuisance in this case, since a non-const reference was necessary but we knew we weren't modifying it anyway.

Solution

It would be nice to be able to specify that write shouldn't increase the version and then be able to increase the version manually later.
@RiscadoA RiscadoA added the S-Triage Issues whose priority still has to be figured out label Oct 5, 2023
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Oct 5, 2023
@RiscadoA RiscadoA added A-Engine B-Assets and removed S-Triage Issues whose priority still has to be figured out labels Oct 5, 2023
@roby2014 roby2014 self-assigned this Oct 16, 2023
@roby2014 roby2014 linked a pull request Oct 17, 2023 that will close this issue
Add flag to control asset versioning when getting write access #727
Open
3 tasks
@RiscadoA RiscadoA removed this from the 0.1 Jammable Engine milestone Jan 29, 2024
@RiscadoA RiscadoA added the P-Backlog This issue isn't a priority at all label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Engine B-Assets P-Backlog This issue isn't a priority at all
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flag to control asset versioning when getting write access GameDevTecnico/cubos
2 participants
@RiscadoA @roby2014