Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: LinuxGSM downloads old script files because GitHub caches files for up to 5 minutes #4528

Closed
MicLieg opened this issue Mar 7, 2024 · 1 comment · Fixed by #4597
Closed

Comments

@MicLieg
Copy link
Contributor

MicLieg commented Mar 7, 2024

User story

As a developer wanting to contribute to LinuxGSM, i want to avoid having to wait for GitHubs cache to expire.

Game

All

Linux distro

Ubuntu 22.04

Command

command: update-lgsm

Further information

When developing LinuxGSM, a developer may want to quickly check that a change works as intended, and update the modules used by LinuxGSM immediately after pushing changes to GitHub. If the changes were pushed too recently, GitHub will cache the old version of the files for up to 5 minutes.

To circumvent this behaviour, Cache-Control and Pragma headers can be added to all curl commands when LinuxGSM's developer mode is enabled. This will force GitHub to respond with the most recent version of the files.

curl -H "Cache-Control: no-cache" -H "Pragma: no-cache" [...] [URL]

Relevant log output

No response

Steps to reproduce

  1. Install any gameserver
  2. Change the LinuxGSM branch (to a branch from a fork)
  3. Push changes to the branch you are using
  4. Remove modules / update LinuxGSM
  5. Download the old version of the changed files from GitHub
    • This may only happen if the files have been requested within the last 5 minutes.
@MicLieg MicLieg added the type: bug Something isn't working label Mar 7, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New Issues in LinuxGSM Backlog Mar 7, 2024
@dgibbs64 dgibbs64 moved this from 🆕 New Issues to 📋 Sentenced Issues in LinuxGSM Backlog Jun 13, 2024
@dgibbs64 dgibbs64 moved this from 📋 Sentenced Issues to 🏗 In Progress in LinuxGSM Backlog Jun 15, 2024
@dgibbs64
Copy link
Member

this is honestly going to be very useful for me.

@dgibbs64 dgibbs64 linked a pull request Jun 15, 2024 that will close this issue
13 tasks
@dgibbs64 dgibbs64 added this to the v24.3.0 milestone Sep 24, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in LinuxGSM Backlog Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants