Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong option check #1

Open
vahid67 opened this issue Oct 6, 2023 · 1 comment
Open

Wrong option check #1

vahid67 opened this issue Oct 6, 2023 · 1 comment

Comments

@vahid67
Copy link

vahid67 commented Oct 6, 2023

Hello,
Thank you for your code.
I am new to this algorithm, but I think there are two bugs in your code.

WaveFunction.cs: In line 116 you should check down neighbours and also in line 150 you should check up neighbours.

Your checks for left & right are correct.

@GarnetKane99
Copy link
Owner

Hey there!
Great pickup - the algorithm that I based this off (or the Pseudocode rather) was using JavaScript I think, so I had to adapt it - and I think I might've had a couple incorrect naming conventions. That being said - the algorithm does work as intended, but the names might not be as straight forward unfortunately

Thanks for the comment - hope it works for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants