-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The R checks for linear regression fail when using Eigen > 3.2.1 #11
Comments
Some more detailed test results:
See also the discussion on the KDE forum: https://forum.kde.org/viewtopic.php?f=74&t=129151&sid=f20413e93d1953f6f1762f6548aa20dc Edit: updated with new data points (3.3-beta2, 3.3.1) |
Strangely enough with Eigen 3.2.8, the linear regression test script passes, but the logistic one fails for the 2df model. One value is one off in the 6th digit when comparing text input with filevector input. |
Hmm, it seems that using Eigen 3.2.8 results in failure of the palinear R test script as well. Output of the 2DF model for test SNP 6 from R:
Output ProbABEL with Eigen 3.2.1:
Output ProbABEL with Eigen 3.2.8:
|
After some discussion on the genabel-devel mailing list we have decided to include Eigen 3.2.1 with the ProbABEL source. This way, this issue won't delay the release of ProbABEL v0.5.0. |
This is a temporary workaround for Issue #11. The full Eigen tar-ball is included as src/3.2.1.tar.bz2 and src/eigen-3.2.1/ contains only the header files.
This is a temporary workaround for Issue #11. The full Eigen tar-ball is included as src/3.2.1.tar.bz2 and src/eigen-3.2.1/ contains only the header files.
One more data point: Eigen version 3.3-beta2 distributed with Ubuntu 16.10 also fails the R check, as does v3.3.1. |
When running
make check
on e.g. an Ubuntu 15.10 machine, the R tests for linear regression fail.The Jenkins tests (http://jenkins.genabel.org) are OK, since that machine runs Ubuntu 14.04 LTS.
Some digging later it turns out that the Eigen library is the source.
The text was updated successfully, but these errors were encountered: