Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The R checks for linear regression fail when using Eigen > 3.2.1 #11

Open
lckarssen opened this issue Nov 8, 2015 · 5 comments
Open

Comments

@lckarssen
Copy link
Member

When running make check on e.g. an Ubuntu 15.10 machine, the R tests for linear regression fail.
The Jenkins tests (http://jenkins.genabel.org) are OK, since that machine runs Ubuntu 14.04 LTS.

Some digging later it turns out that the Eigen library is the source.

@lckarssen
Copy link
Member Author

lckarssen commented Nov 9, 2015

Some more detailed test results:

  • 3.2.0 OK (in Ubuntu 14.04)
  • 3.2.1 OK
  • 3.2.2 BROKEN
  • 3.2.3 BROKEN
  • 3.2.5 BROKEN (in Ubuntu 15.10)
  • 3.3-alpha1 BROKEN
  • 3.2 "current" (e059accf541a) BROKEN
  • 3.3-beta2 BROKEN (in Ubuntu 16.10)
  • 3.3.1 BROKEN

See also the discussion on the KDE forum: https://forum.kde.org/viewtopic.php?f=74&t=129151&sid=f20413e93d1953f6f1762f6548aa20dc

Edit: updated with new data points (3.3-beta2, 3.3.1)

@lckarssen lckarssen added the bug label Nov 21, 2015
@lckarssen lckarssen added this to the v0.5.0 milestone Nov 21, 2015
@lckarssen
Copy link
Member Author

lckarssen commented Apr 22, 2016

Strangely enough with Eigen 3.2.8, the linear regression test script passes, but the logistic one fails for the 2df model. One value is one off in the 6th digit when comparing text input with filevector input.

@lckarssen
Copy link
Member Author

lckarssen commented Apr 26, 2016

Hmm, it seems that using Eigen 3.2.8 results in failure of the palinear R test script as well.

Output of the 2DF model for test SNP 6 from R:

 beta_SNP_A1A2 sebeta_SNP_A1A2 beta_SNP_A1A1 sebeta_SNP_A1A1 chi2_SNP_2df
 6.734722        6.490411            NA              NA              1.0975797 

Output ProbABEL with Eigen 3.2.1:

rs3174230 G C 0.8123 1.2e-05 0.9991 0.0185 182 0.997253 19 7845238 0 0 -6.73472 6.50872 1.09758

Output ProbABEL with Eigen 3.2.8:

rs3174230 G C 0.8123 1.2e-05 0.9991 0.0185 182 0.997253 19 7845238 352 7.683e+07 345.265 7.683e+07 1.09758

@lckarssen
Copy link
Member Author

After some discussion on the genabel-devel mailing list we have decided to include Eigen 3.2.1 with the ProbABEL source. This way, this issue won't delay the release of ProbABEL v0.5.0.

@lckarssen lckarssen modified the milestones: v1.0.0, v0.5.0 May 3, 2016
lckarssen added a commit that referenced this issue May 4, 2016
This is a temporary workaround for Issue #11.
The full Eigen tar-ball is included as src/3.2.1.tar.bz2 and
src/eigen-3.2.1/ contains only the header files.
lckarssen added a commit that referenced this issue May 4, 2016
This is a temporary workaround for Issue #11.
The full Eigen tar-ball is included as src/3.2.1.tar.bz2 and
src/eigen-3.2.1/ contains only the header files.
@lckarssen
Copy link
Member Author

lckarssen commented Dec 22, 2016

One more data point: Eigen version 3.3-beta2 distributed with Ubuntu 16.10 also fails the R check, as does v3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant