Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend simulation functions to allow for custom covariates #327

Open
gowerc opened this issue May 20, 2024 · 1 comment
Open

Extend simulation functions to allow for custom covariates #327

gowerc opened this issue May 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gowerc
Copy link
Collaborator

gowerc commented May 20, 2024

Currently the survival simulation function is hard coded to only have 2 linear covariates cov_cat and cov_cont. Would be good to extend this somehow to allow for a more flexible specification from the SimSurvial objects.

@gowerc gowerc added the enhancement New feature or request label May 20, 2024
@gowerc
Copy link
Collaborator Author

gowerc commented May 20, 2024

For reference this is pseudo already implemented via the sampleSubjects.SimSurvival method which could have sub-class specific implementations. Only problem is that sampleObservations.SimSurvival appears to be hard coded to look for the cov_cat and cov_cont variables which would need to be fixed. I'm not sure where else these variables are hard coded either. Might need some thinking about detaching this definition from the baseline-hazard though as at the moment you'd have to redefine all your survival distributions if you change the method (maybe this is fine?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant