Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad macro expansion for keyword arguments #9

Open
nstiurca opened this issue Mar 19, 2023 · 5 comments
Open

Bad macro expansion for keyword arguments #9

nstiurca opened this issue Mar 19, 2023 · 5 comments
Assignees

Comments

@nstiurca
Copy link

Minimal working example:

module MacroBugMWE

using GenieFramework
@genietools

fun(foo; bar) = foo * bar

@handlers begin
  @in foo = "foo"
  @in bar = "bar"
  @out biz = ""
  @in myButton = false

  @onbutton myButton begin
      biz = fun(foo; bar)
  end
end

end

Results in

syntax: invalid keyword argument syntax "__model__.bar[]" around macro-bug-mwe.jl:15
@nstiurca
Copy link
Author

julia> versioninfo()
Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake)
  Threads: 1 on 8 virtual cores
Environment:
  JULIA_PROJECT = @.
  JULIA_EDITOR = code
  JULIA_NUM_THREADS = 
  JULIA_REVISE = auto

Package info:

[a59fdf5c] GenieFramework v1.12.0

@AbhimanyuAryan AbhimanyuAryan self-assigned this Mar 19, 2023
@AbhimanyuAryan
Copy link
Member

thanks

@hhaensel
Copy link
Member

hhaensel commented Sep 8, 2023

I had already removed that bug for @onchange and had not realised it still exists for @onbutton.
Will look into this.

@hhaensel
Copy link
Member

Found it and fixed it in the branch hh-page, that will soon be merged

@hhaensel
Copy link
Member

hhaensel commented Sep 18, 2023

@nstiurca Should be solved with the latest version of Stipple. Could you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants