Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 14 Beta 5 crop not working (Pixel 6 Pro) #4162

Open
2 tasks done
dhwz opened this issue Jul 13, 2023 · 9 comments
Open
2 tasks done

Android 14 Beta 5 crop not working (Pixel 6 Pro) #4162

dhwz opened this issue Jul 13, 2023 · 9 comments

Comments

@dhwz
Copy link

dhwz commented Jul 13, 2023

  • I have read the FAQ.
  • I have searched in existing issues.

Environment

  • OS: Windows 11
  • scrcpy version: 2.1
  • installation method: Win x64 from GitHub
  • device model: Pixel 6 Pro
  • Android version: 14 Beta 4

Describe the bug
Tried to crop the black bar from the screen which is always visible on Pixel 6 Pro in Landscape mode. It worked perfectly on Android 13
but crop is completely ignored on Android 14 Beta 4

--crop 1440:2600:0:120 removed the black bar on Android 13 but doesn't do anything on Android 14
Note: Mouse position is still wrong if the crop is applied and also the scrcpy output says it has cropped
INFO: Texture: 1440x2480 vs. INFO: Texture: 1440x2600 if crop is 0

scrcpy.exe -w --video-bit-rate 25M --video-codec=h265 --audio-bit-rate=256K --audio-codec=opus --crop 1440:2600:0:120
scrcpy 2.1 <https://github.com/Genymobile/scrcpy>
C:\STORAGE\scrcpy-win64-v2.0\scrcpy-server: 1 file pushed, 0 skipped. 77.6 MB/s (56955 bytes in 0.001s)
[server] INFO: Device: [Google] google Pixel 6 Pro (Android 14)
INFO: Renderer: direct3d
INFO: Texture: 2480x1440
INFO: Texture: 1440x2480
[server] INFO: Device rotation requested: landscape
INFO: Texture: 2480x1440
@dhwz dhwz changed the title Android14 Beta4 crop not working (Pixel 6 Pro) Android 14 Beta 5 crop not working (Pixel 6 Pro) Aug 11, 2023
@dhwz
Copy link
Author

dhwz commented Aug 11, 2023

@rom1v installed Beta 5 now, seems it's still broken. Do you have any idea what has changed from Android 13?

@rom1v
Copy link
Collaborator

rom1v commented Aug 11, 2023

Nope, I don't know, they changed things related to display, which also broke --turn-screen-off (#3784). To be investigated (once the source code of Android 14 is released)…

@SharkWipf
Copy link

FWIW: seems like the source is released now: https://android-developers.googleblog.com/2023/10/android-14-is-live-in-aosp.html

I can also confirm crop not working* on the Pixel 8 Pro, so nothing's changed there since beta it seems.

* The inputs do get "cropped" though, so any touches go to wrong places.

@rom1v
Copy link
Collaborator

rom1v commented Oct 25, 2023

See #4011

rom1v added a commit that referenced this issue Oct 28, 2024
The options --lock-video-orientation and --crop are broken since Android
14. Hopefully, they will be reimplemented differently.

Meanwhile, when running Android >= 14, fail with an error to prevent
incorrect behavior.

Refs #4011 <#4011>
Refs #4162 <#4162>
rom1v added a commit that referenced this issue Oct 31, 2024
The options --lock-video-orientation and --crop are broken since Android
14. Hopefully, they will be reimplemented differently.

Meanwhile, when running Android >= 14, fail with an error to prevent
incorrect behavior.

Refs #4011 <#4011>
Refs #4162 <#4162>
PR #5417 <#5417>
@rom1v
Copy link
Collaborator

rom1v commented Nov 11, 2024

Please test #5455.

@dhwz
Copy link
Author

dhwz commented Nov 11, 2024

@rom1v Thank you very much, can you provide updated binaries so I can test it?

@MeisterP
Copy link

Please test #5455

Cropping is working again. Tested on a Pixel 6a with LineageOS 21.0

@rom1v
Copy link
Collaborator

rom1v commented Nov 15, 2024

Please test a new version in #5455, a binary is provided.

@dhwz
Copy link
Author

dhwz commented Nov 18, 2024

Thanks again, verified it's working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants