Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytmd_model.format tests in coastal module need updating for latest pyTMD #1265

Open
jessjaco opened this issue Sep 17, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@jessjaco
Copy link

jessjaco commented Sep 17, 2024

The various tests for pytmd_model.format in coastal.py, e.g.

if pytmd_model.format in ("OTIS", "ATLAS", "TMD3"):

need to be updated for the new values in pyTMD.model of ATLAS-compact, FES-ascii, FES-netcdf, etc. listed here: https://github.com/tsutterley/pyTMD/blob/0f6a07c8723a67b02eade42feb211df8a78b8321/pyTMD/io/model.py#L148-L158

I believe pyTMD version 2.1.4 is the last working version.

@jessjaco jessjaco added the bug Something isn't working label Sep 17, 2024
@robbibt
Copy link
Member

robbibt commented Sep 18, 2024

Thanks @jessjaco - pinning to pyTMD 2.1.4 is the best temporary solution - feel free to raise a PR here pinning that version in our setup.py!

https://github.com/GeoscienceAustralia/dea-notebooks/blob/develop/Tools%2Fsetup.py#L59

We should chat about this in more detail at some point - we're currently in the process of spinning off all our tide modelling to a smaller, easier to install Python package (eo-tides). Should make managing changes to the tide modelling code much easier in the the future!

@jessjaco
Copy link
Author

Ok, I noticed some of the recent updates to pyTMD and I'm just trying to stay on top of them. (The addition of the crop functionality helped speed things up a lot.) Looking forward to hearing about the new package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants