Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do #3

Open
7 of 12 tasks
jhcreed opened this issue Aug 29, 2019 · 4 comments
Open
7 of 12 tasks

To Do #3

jhcreed opened this issue Aug 29, 2019 · 4 comments

Comments

@jhcreed
Copy link
Member

jhcreed commented Aug 29, 2019

  • Allow character covariates - currently only work with numeric
  • Find public dataset for paper and to include in /data
  • Version number
  • Add cox survival
  • Fix up README
  • Resolve open issues
  • Remove warning issue from rbind (Sigmas)
  • Add flag for PM CI (default to FALSE; TRUE would trigger bootstrap for CI)
  • Add progress bar for running boot
  • Double check boot for survival outcomes
  • Set up .com travis
  • Have @gadenbuie double check new boot methods and parallel (future/furrr)
@jhcreed
Copy link
Member Author

jhcreed commented Mar 17, 2020

Hey @gadenbuie if you get a sec can you check out the progress bar? I have tried it like a million different ways and can't seem to get it to trigger. If not no issue.

@jhcreed
Copy link
Member Author

jhcreed commented Mar 31, 2020

Progress bar works using boot::boot(data = data, statistic = CIs, R = boot_rep) but not when using the parallelization in boot boot::boot(data = data, statistic = CIs, R = boot_rep, parallel = "multicore", ncpus = parallel::detectCores(logical = FALSE)) so either leave as is or figure out a work around

@gadenbuie
Copy link
Member

Hey @jhcreed sorry I didn't see the comment from 2 weeks ago until now. Took a quick look and I don't think it's possible to add progress bars for the boot::boot() process. As far as I can tell, that's not something that's built into the function and there's no way to have each iteration trigger a callback function.

If your functions call many boot::boot()s, then a progress bar might be possible. If that's the case, can you point me to the for loop in your code where you wan the progress bar?

@jhcreed
Copy link
Member Author

jhcreed commented Mar 31, 2020

It works inside the boot::boot() just not when I use the parallel = "multicore", ncpus = parallel::detectCores(logical = FALSE) options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants