Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect name of the ModifiableScheduledTask parameter. #28

Open
hasksomatotoian opened this issue Feb 14, 2024 · 0 comments · May be fixed by #29
Open

Incorrect name of the ModifiableScheduledTask parameter. #28

hasksomatotoian opened this issue Feb 14, 2024 · 0 comments · May be fixed by #29

Comments

@hasksomatotoian
Copy link

hasksomatotoian commented Feb 14, 2024

Steps to Reproduce

Run SharpUp with the ModifiableScheduledTask parameter and verify that no checks were run:

[*] Audit mode: running an additional 0 check(s).

Root Cause of the Issue

That's because the check class is named differently, ModifiableScheduledTaskFile (notice the File at the end), so the ModifiableScheduledTask parameter does not invoke it.

Proposed Solution

There are two options for solving this:

  • Rename the parameter in the documentation from ModifiableScheduledTask to ModifiableScheduledTaskFile
  • Rename the check class to ModifiableScheduledTask

I propose choosing the latter option, as it is a quick internal change and people won't have to modify their scripts and checklists (even if they haven't worked so far).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant