Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide endpoint showing all givbacks eligible recurring donations enabled projects #1879

Closed
divine-comedian opened this issue Nov 26, 2024 · 5 comments
Assignees

Comments

@divine-comedian
Copy link
Collaborator

for superfluid drop project we should help them out by exposing an endpoint which can provide some information about recurring donation eligible projects. Projects returned in the api call should meet the following criteria:

  • have anchor contract address on project data (on base or optimism)
  • has status of givbacks eligible

we should provide the following project data for each project returned in the response:

  • anchor contract address
  • id
  • slug
  • title
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Nov 26, 2024
@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Nov 26, 2024
@divine-comedian divine-comedian modified the milestone: SuperFluid Drop Dec 3, 2024
@CarlosQ96
Copy link
Collaborator

I assume instead of a anchor contract address. And array of active contract addresses by network. Since they can have more than one now with optimism and base.

@CarlosQ96 CarlosQ96 moved this from Dev Research to Product Backlog in All-Devs Dec 12, 2024
@CarlosQ96 CarlosQ96 moved this from Product Backlog to In Progress in All-Devs Dec 12, 2024
@divine-comedian
Copy link
Collaborator Author

divine-comedian commented Dec 12, 2024

@CarlosQ96 will we be able to distinguish which is the base address and which is optimism? it might be helpful on their side to know.

Even if we placed the addresses in the array in a consistent position, like anchorContracts[0] is Optimism and anchorContracts[1] is Base

@CarlosQ96
Copy link
Collaborator

@divine-comedian I think ill add an array with the network something like

{ 
  id: string,  
  slug: string,
  title: string,
  anchorContracts: [
    { address: string, networkId: number }, 
    { address: string, networkId: number },
  ]
}

@CarlosQ96 CarlosQ96 moved this from In Progress to Code Review/PR in All-Devs Dec 16, 2024
@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Dec 17, 2024
@divine-comedian
Copy link
Collaborator Author

@CarlosQ96 can you provide the endpoint details for when we are ready to test it

@CarlosQ96
Copy link
Collaborator

CarlosQ96 commented Dec 21, 2024

export const recurringDonationEligibleProjectsQuery = `
  query (
    networkId: Int
    page: Int
    limit: Int
  ) {
    recurringDonationEligibleProjects {
      id
      slug
      title
      anchorContracts {
        address
        networkId
      }
    }
  }
`;

@divine-comedian

@github-project-automation github-project-automation bot moved this from QA to Done in All-Devs Jan 2, 2025
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged to Production
Development

No branches or pull requests

2 participants