Skip to content
This repository has been archived by the owner on Dec 30, 2024. It is now read-only.

Rename primaryVault and topUpVault #17

Open
adria0 opened this issue Apr 20, 2017 · 5 comments
Open

Rename primaryVault and topUpVault #17

adria0 opened this issue Apr 20, 2017 · 5 comments

Comments

@adria0
Copy link

adria0 commented Apr 20, 2017

Since there's no secondary vaults, consider renaming primaryVault property to vault
Consider renaming topUpVault() to topUpCallerVault()

@adria0 adria0 changed the title Rename primaryVault to vault Rename variables Apr 20, 2017
@adria0 adria0 changed the title Rename variables Rename primaryVault and topUpVault Apr 20, 2017
@jbaylina
Copy link
Contributor

@GriffGreen ^^

@GriffGreen
Copy link
Member

I think there needs to be a qualifier in front of vault because there are so many vaults.

The primaryVault is special because it is generated first and has no parentVault (which should be renamed to overflowDestination I guess thats a different issue)

If you dont like primaryVault how about genesisVault @AdriaMB

https://youtu.be/qOyF4hR5GoE?t=24s

@ghost
Copy link

ghost commented May 5, 2017

I like these:

genesisVault
originVault
sourceVault
rootVault
masterVault
alphaVault
ownerVault
startingVault
firstVault
progenitorVault

@GriffGreen
Copy link
Member

GriffGreen commented May 5, 2017

@jbaylina I like primaryVault = genesisVault :-D @AdriaMB was calling it rootVaultthats not too bad either if you don't like genesis... but I like the crypto-ish genesisreference.

@daniphilia what do you think about changing parentVault to overflowDestination? any better words?

@ghost
Copy link

ghost commented May 11, 2017

masterDelegate?tokenShepherd?fundShepherd?:

the masterDelegate* is the shepherd of the initial fund of tokens, issuing the fund to the root node of the family tree, and acting as the resolver of all sorts of conflicts, including: fund overflows, cancelled funds, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants