-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's not possible to remove ETH/Tokens from a canceled vault. #20
Comments
Should it be sent to the main vault, or to an address provided by the caller? |
Ideally if a vault is cancelled. all of the balance should go to parent vault by default. |
Right now, when you cancel a voult, you cancel all the vaults under that vault also. And the Ether is sent to the parent vault. |
What should happen to the Ether sent to the cancelled vault? Should it just be sent to the |
if you try to send ether to a canceled vault it should throw right? it doesnt have a Now, this is where I would hope that the escape hatch can be used. I know jordi doesn't like planning to use it in the code, but this is an edge case that I think it would cover... In my mind this is not a real issue because of the escape hatch is here for these edge cases... I want to illustrate a relevant example: When we were making the hard fork withdraw contract for The DAO, we kept it very simple because there is security in simplicity: https://etherscan.io/address/0xbf4ed7b27f1d666546e30d74d50d173d20bca754#code The However, I use the This is not it's intended use, but it works great, it's actually kind of funny but if you send DAO tokens to the withdraw contract, and tell me about it i can call This would be the same mechanism we have if we use the escapeHatch and it would save us A LOT of complexity, and i don't think it is a misuse of that function. |
Another option is to add a
|
A specific function should be created to allow that.
The text was updated successfully, but these errors were encountered: