Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring into ~4 contracts (or more) #48

Open
GriffGreen opened this issue May 1, 2017 · 0 comments
Open

Consider refactoring into ~4 contracts (or more) #48

GriffGreen opened this issue May 1, 2017 · 0 comments

Comments

@GriffGreen
Copy link
Member

I think that some of these features may not want to be used by all users...

We might consider refactoring the code to have the core functionalities that are mandatory (I would suggest keeping the whitelistTimeLock as the most basic contract, the childVault stuff as an extension, the limits as an extension, and the open close time as an extension.

I know this is much easier said than done... but it would make the contracts much easier to understand and would allow people that don't want to include certain features to avoid deploying the extra code

This is a major design change. I expect a good healthy debate in this thread :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant