Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize terrain.py methods #302

Open
rhugonnet opened this issue Sep 13, 2022 · 1 comment · May be fixed by #486
Open

Vectorize terrain.py methods #302

rhugonnet opened this issue Sep 13, 2022 · 1 comment · May be fixed by #486
Labels
priority Needs to be fixed rapidly

Comments

@rhugonnet
Copy link
Contributor

This is planned for soon, using the convolutions added in #292 (moved to GeoUtils eventually, #300)
Also, to echo a comment in #301, we should define the output dtypes of terrain attributes and use the default nodata of GeoUtils via `raster._default_ndv()'.
@rhugonnet rhugonnet mentioned this issue Sep 13, 2022
Merged
@rhugonnet rhugonnet added the priority Needs to be fixed rapidly label Aug 1, 2023
@erikmannerfelt
Copy link
Contributor

What exactly do you mean with vectorize? Speed up? The np.vectorize decorator won't work as it's using numba, not numpy for the brunt of the work.

@rhugonnet rhugonnet linked a pull request Mar 12, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority Needs to be fixed rapidly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speed-up terrain attribute calculation using convolution rhugonnet/xdem
2 participants
@rhugonnet @erikmannerfelt