Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efficient pixel-wise time series statistical regression: least-squares, GP, etc.. #52

Closed
rhugonnet opened this issue Mar 14, 2021 · 3 comments
Assignees
Labels
new-feature A new functionality / feature or request

Comments

@rhugonnet
Copy link
Contributor

Existing work here: https://github.com/iamdonovan/pyddem/blob/master/pyddem/fit_tools.py#L2093
To scale GP application matricially, kernel learning automated methods, need to add methods implemented in: https://gpytorch.ai/

@rhugonnet rhugonnet added the enhancement Feature improvement or request label Mar 14, 2021
@rhugonnet rhugonnet self-assigned this Mar 14, 2021
@erikmannerfelt erikmannerfelt added new-feature A new functionality / feature or request and removed enhancement Feature improvement or request labels Jul 2, 2021
@rhugonnet
Copy link
Contributor Author

2 years later: this should live in an independent package (time series analysis is not specific to DEMs), I think our efforts should now focus on https://github.com/friedrichknuth/gtsa.

However, it would be good to have a way somehow to "store" the best GP parameters specific to DEMs for easy user applications... GTSA could have a dem submodule storing those, or should it be called by xDEM and exemplified to do that? What do you think @friedrichknuth?

@friedrichknuth
Copy link
Contributor

@rhugonnet thanks for the pointer to GTSA! It would be fantastic to have more hands on deck with this effort. I am also happy to transfer the repo to a broader organization when exposure/momentum builds and we feel the time is right.

With regards to storing DEM specific GP parameters - it is a good question and I'm not sure yet 🤔 I think a submodule in GTSA might make most sense since the parameters will be primarily related to time series analysis and avoiding dependencies is generally beneficial.

I envision a submodule for GP, then perhaps a class within that provides parameters for DEMs and subclasses for different earth surface types. Right now the primary use cases for GTSA will be DEM related, but there is potential for stacking and analyzing other raster datasets. If GP is the right tool for these products then they could receive their own class and subclasses within the GP module.

These are my preliminary thoughts but I'm open to whatever makes most sense!

@rhugonnet
Copy link
Contributor Author

I agree, a "thematic" submodule in GTSA makes the most sense for storing DEM parameters!
We might end up doing the same in xDEM for things specific to glacier, snow, geomorpho applications... right now we focused on things that were generic to DEMs.

For the time series analysis tools, it might be worth to have a look at what they recently added in GeoWombat (also based on dask/xarray) and how they organized it: https://geowombat.readthedocs.io/en/latest/gpu.html.
It could also be good to drop them a message to coordinate with GTSA, I already did the same on Xarray accessors for geoutils/DEM, with discussions in Xarray/Rioxarray/GeoWombat etc (#392, GlacioHack/geoutils#383) (it's fine on the Rioxarray/Xarray side, so I'm starting on it 😉!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new functionality / feature or request
Projects
None yet
Development

No branches or pull requests

3 participants