Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shiny Charm not granted after reaching level 50 #838

Open
FlareHD opened this issue May 6, 2024 · 1 comment · May be fixed by #849
Open

Shiny Charm not granted after reaching level 50 #838

FlareHD opened this issue May 6, 2024 · 1 comment · May be fixed by #849
Assignees
@Glazelf @Skaidus
Labels
bug Something isn't working

Comments

@FlareHD
Copy link
Contributor

FlareHD commented May 6, 2024

When you reach Level 50 for your shinx, it should allow you to change your shinx into a shiny version with the command /shinx shiny. However, it does not let you change your shinx as the shiny charm is not given to the user once reaching level 50.

Steps to reproduce the behavior:

  1. Go to wherever you use the bot
  2. Reach level 50 with your shinx
  3. Use the command /shinx shiny

Screenshots
image
@FlareHD FlareHD added the bug Something isn't working label May 6, 2024
@Glazelf
Copy link
Owner

Glazelf commented May 6, 2024

addExperience() function might be bugged?

NinigiBot/database/dbServices/shinx.api.js

Lines 49 to 58 in 0e421cb

async addExperience(id, experience) {
let shinx = await this.getShinx(id, ['user_id', 'experience']);
const res = await shinx.addExperienceAndLevelUp(experience);
if (res.pre != res.post) {
if (hasPassedLevel(res.pre, res.post, 5)) await this.addEventTrophy(id, 'Bronze Trophy');
if (hasPassedLevel(res.pre, res.post, 15)) await this.addEventTrophy(id, 'Silver Trophy');
if (hasPassedLevel(res.pre, res.post, 30)) await this.addEventTrophy(id, 'Gold Trophy');
if (hasPassedLevel(res.pre, res.post, 50)) await this.addEventTrophy(id, 'Shiny Charm');
};
},

@T1biriy T1biriy mentioned this issue May 14, 2024
Closed
@Glazelf Glazelf linked a pull request May 15, 2024 that will close this issue
Fix Event Trophies #849
Draft
@Glazelf Glazelf assigned Glazelf and unassigned Glazelf Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glazelf Glazelf

@Skaidus Skaidus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Event Trophies Glazelf/NinigiBot
Fix item distribution on level tresholds T1biriy/NinigiBot
3 participants
@Glazelf @Skaidus @FlareHD