utils function calc_dive_number

[sarahnicholson]

Hi,

Im encountering an issue with the utils.calc_dive_number that I need some help with and im not quite yet confident enough to report it as a bug? I am currently loading in raw sbd data from a slocum platform via dbdreader and i'm using the glidertools function gt.utils.calc_dive_number. The resulting plot of dive, depth, temp has all of the down dives plotted first and then all of the updives dives instead of alternating i.e., it looks like a repeated section.

The gt.utils.calc_dive_number calls the function "gt.utils.calc_dive_phase". The dive phase function gt.utils.calc_dive_phase has been based on the EGO dive phase definitions where down dives are 1 and up dives are 4 (see here http://www.coriolis.eu.org/content/download/20631/142573/file/groom_gliders_user_manual-version1.1-sandiego.pdf, page 21), however i suspect the utils.calc_dive_number is still based on the previous version of the dive phase where down dives are x.0 and up dives are x.5. Particularly this line of the code in gt.utils.calc_dive_number : dive = (u_dive + d_dive) / 2

Anyone else encounter this issue? Any work arounds?
Thanks very much
Sarah

[lukegre]

This might need a platform specific approach that makes use of glider engineering data. I remember this being a bit hacky when I put it together. I struggled having a unified approach for both Slocum and SeaGlider.