New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global.nalg.c uses static work arrays, dead code, and a bug #19

Open

jeffdaily opened this issue Apr 5, 2017 · 0 comments

Labels

bug cleanup thread-safety

Member

jeffdaily commented Apr 5, 2017

/* work arrays used in all routines */
static Integer dims[MAXDIM], ld[MAXDIM-1];
static Integer lo[MAXDIM],hi[MAXDIM];
static Integer one_arr[MAXDIM]={1,1,1,1,1,1,1};

Move these work array into the functions.

On a side note, snga_copy_old() might be dead code.
Bug found in snga_local_transpose() where it uses an int instead of an Integer type.

jeffdaily added bug cleanup thread-safety labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment