Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiter on all APIs #10

Open
Mustafiz04 opened this issue Sep 22, 2024 · 5 comments · May be fixed by #27
Open

Add rate limiter on all APIs #10

Mustafiz04 opened this issue Sep 22, 2024 · 5 comments · May be fixed by #27
Assignees
Labels
enhancement New feature or request gssoc-ext hacktoberfest HacktoberFest 2024 linked issue hacktoberfest-accepted level 3

Comments

@Mustafiz04
Copy link
Member

Mustafiz04 commented Sep 22, 2024

Add rate limit on all APIs. We are just starting but still, we don't allow anyone to abuse our APIs

5 requests per second (just a random number I gave)

If you have a different number for supper, we can discuss it.

@Targter
Copy link

Targter commented Oct 10, 2024

Issues:

  • Currently, there is no rate-limiting mechanism on the APIs, which leaves them vulnerable to abuse or excessive usage.
  • This could potentially lead to performance degradation, server overload, or resource abuse if not addressed.
  • To maintain the quality of service, we need to restrict the number of requests made to the APIs within a specific time frame.

Solution:

  • Implement rate limiting on all APIs to ensure fair usage and prevent abuse.
  • I propose setting a limit of 5 requests per second as a starting point (subject to discussion if a different rate is preferred).
  • This will help to balance server performance while providing users with a reasonable request rate.

@GlobeHoppin @Mustafiz04

Please add the labels for GSSoC-EXT and Hacktoberfest and assign this issue to me.

@Mustafiz04
Copy link
Member Author

Write function like we can configure rate limit, algorithm and so on.

@Mustafiz04
Copy link
Member Author

Hi, @Targter can you please give an update on your progress?

@Tiwariji-07 Tiwariji-07 linked a pull request Oct 12, 2024 that will close this issue
@Targter
Copy link

Targter commented Oct 13, 2024 via email

@Targter
Copy link

Targter commented Oct 13, 2024

I have submitted a pull request for your review. Please let me know if you encounter any issues, and I would be happy to discuss further. @Mustafiz04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext hacktoberfest HacktoberFest 2024 linked issue hacktoberfest-accepted level 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants