Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to glow CLI #219

Open
3 of 14 tasks
kwannoel opened this issue Sep 22, 2021 · 19 comments
Open
3 of 14 tasks

Improvements to glow CLI #219

kwannoel opened this issue Sep 22, 2021 · 19 comments
Labels
Doing

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Sep 22, 2021 •
edited
Loading

In GitLab by @kwanzknoel on Sep 10, 2021, 02:06

  • glow should tell users to do something actionable if required options are missing.

    For example for glow add-contact, the -N flag is required:

    > glow add-contact
Glow v0.3.0 on Gerbil-ethereum v0.0-344-g266204c, Gerbil-persist v0.0-19-g75d4c45, Gerbil-crypto v0.0-16-g4c7c4a8, Gerbil-POO v0.0-96-g8ab28ef, Gerbil-utils v0.2-134-g124e025, Gerbil v0.16-192-gfa9537be, Gambit 4.9.3-1447-gc0753ff1
In thread primordial:
0  mukn/glow/cli/contacts#add-contact__%                                       
1  ##dynamic-env-bind                                                          
2  ##call-with-values                                                          
3  clan/exit#call-print-exit                                                   
4  ##dynamic-env-bind                                                          
5  ##start-main                                                                
6  ##kernel-handlers                                                           
*** ERROR IN mukn/glow/cli/contacts#add-contact__% -- missing name

    (Preferred) If options are missing,
    use get-or-ask to prompt user to input the missing option.

    We could also tell users to use glow help add-contact to view the argument schema.
    See example.

    Implement this for the following entrypoints:

  • Have defaults for max initial block if no input is entered (https://gitlab.com/mukn/glow/-/merge_requests/177):

    Max initial block [ Current block number is 2475 ]
> 
Glow 0.3.0 on Gerbil-ethereum v0.0-344-g266204c, Gerbil-persist v0.0-19-g75d4c45, Gerbil-crypto v0.0-16-g4c7c4a8, Gerbil-poo v0.0-96-g8ab28ef, Gerbil-utils v0.2-134-g124e025, Gerbil v0.16-192-gfa9537be, Gambit 4.9.3-1447-gc0753ff1
*** ERROR IN mukn/glow/cli/interaction#ask-max-initial-block -- type-error Nat [value: #f]

  • Prompt again if user does not enter a valid input, instead of erroring out. https://gitlab.com/mukn/glow/-/issues/219

  • Command for checking account balances #402

  • Come up with a way to derive / share user databases, instead of requiring them to supply these explicitly e.g. --database bob. This will require refactoring gerbil-ethereum/tx-tracker#post-transaction which calls open-transaction from gerbil-persist and the start-interaction entrypoint(s).
@kwannoel kwannoel added the Doing label Sep 22, 2021
@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 10, 2021, 02:09

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 10, 2021, 02:13

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 10, 2021, 02:24

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 10, 2021, 02:26

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 10, 2021, 02:28

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 11, 2021, 02:26

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 11, 2021, 02:47

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 11, 2021, 03:14

changed the description

1 similar comment
@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 11, 2021, 03:14

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 16, 2021, 01:23

marked the task Have defaults for max initial block if no input is entered (https://gitlab.com/mukn/glow/-/merge_requests/177): as completed

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 16, 2021, 02:37

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 16, 2021, 02:38

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 16, 2021, 03:06

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 17, 2021, 03:46

mentioned in merge request !178

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 17, 2021, 03:47

changed the description

1 similar comment
@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 17, 2021, 03:47

changed the description

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 17, 2021, 23:03

  • Add context to define-entrypoint so user knows exactly where they went wrong.
  • So we can also introspect the options within define-entrypoint

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 18, 2021, 03:36

assigned to @kwanzknoel

@kwannoel
Copy link
Contributor Author

In GitLab by @kwanzknoel on Sep 18, 2021, 04:15

changed the description

zenhack pushed a commit to zenhack/glow that referenced this issue Jan 18, 2022
@kwannoel
Merge branch 'kwannoel/check-input' into 'master'
2a41b86 
Re-request invalid parameter for ask-option

Closes Glow-Lang#219

See merge request mukn/glow!180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwannoel