Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts DB needs love #437

Open
fare opened this issue Feb 25, 2022 · 1 comment
Open

Contacts DB needs love #437

fare opened this issue Feb 25, 2022 · 1 comment

Comments

@fare
Copy link
Contributor

fare commented Feb 25, 2022

  • Many attempts to add-identity result in failure with *** ERROR IN std/db/dbi#sql-exec -- sqlite-exec: [sql-error] SQLite error: constraint failed at which point a parasitic anonymous contact is created. TODO: figure out the error, have better error message, use transaction to make the failure atomic.
  • You can't add a contact address without an identity(!)

The entire contacts database needs a bit of love.

@fare
Copy link
Contributor Author

fare commented Mar 1, 2022

I started a notion document for re-designing the contacts db:
https://www.notion.so/mukn/Contact-DB-design-93f714e1cb6946209e3103e6b61e894e

As for how to represent the data on disk, I also started another notion document for how I think we should or shouldn't persist data:
https://www.notion.so/mukn/Glow-Persistence-65aedf3fee1542b1975b614538010cf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant