Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features I might work on myself #95

Open
75th opened this issue Aug 19, 2024 · 9 comments
Open

New features I might work on myself #95

75th opened this issue Aug 19, 2024 · 9 comments
Assignees
Labels
question Further information is requested

Comments

@75th
Copy link

75th commented Aug 19, 2024

If my procrastination habits and lack of focus allow, I might contribute some upgrades to this, if they'd be welcome. I thought I would put all my pipe dreams here so that if any of them aren't well liked I can not focus on those, or at least not bother with pull requests.

  • Optional mode to track collection across multiple NG+ cycles. A separate column of checkboxes for each journey, which are totaled on the left (for items where multiples are useful — mostly just weapons)
  • New list of Larval Tears with brief location descriptions
  • New list of Wandering Mausoleums and remembrance duplication coffins
    • Possibly also allow denoting which remembrance was duplicated, throwing warnings when duplicating a non-shardbearer remembrance at a belled mausoleum, disabling some checkboxes when no longer obtainable in this journey, etc.
  • Two checkboxes on non-paired weapons that can be dual-wielded
    • In multiple-cycles mode, some indication as to when at least two have been collected on the left, and then either one or two checkboxes in each NG column depending on whether more than one is obtainable per playthrough
  • Some indication as to whether altered armor pieces are gained by alteration or as separate drops
  • Some understandable indication for each item when it has unique instances and/or is farmable, is missable vs. unmissable, etc.
  • Disabling or marking missable Leyndell items after Maliketh's box is checked in the Bosses list.
    • Or perhaps the reverse of this: Put a warning indication on Maliketh's entry when all Leyndell items aren't collected yet
    • Possibly mark other missables based on progress? Mark things like High Page Clothes that are still farmable after Maliketh but way more painfully?
  • Option to sort weapons by menu order instead of alphabetically
  • Denote armor subgroups within each body part list
  • Move some/most list data from JS files to CSV files (or files of some other format) that are parsed by JS?

Some of these might seem silly to add at this late date, but could be nice to have done for whenever Fromsoft drops its next Souls game. Let me know what you think, and we'll see if I can get the gumption to actually do some of this work.

@Gobluebro
Copy link
Owner

Quick question

Move some/most list data from JS files to CSV files (or files of some other format) that are parsed by JS?

What is the problem that csv would be fixing in this case?

@Gobluebro Gobluebro self-assigned this Aug 19, 2024
@Gobluebro Gobluebro added the question Further information is requested label Aug 19, 2024
@Gobluebro
Copy link
Owner

Gobluebro commented Aug 19, 2024

Option to sort weapons by menu order instead of alphabetically

This is the goal. I have the weapons I just need to sort them by how they appear in game. It's tough because they were given groups that don't exist in game iirc

@Gobluebro
Copy link
Owner

Denote armor subgroups within each body part list

What's a sub group in armor? They are sorted currently by how they appear in game order. There is no sub groups in game only horizontal rules

@Gobluebro
Copy link
Owner

Some of these might seem silly to add at this late date, but could be nice to have done for whenever Fromsoft drops its next Souls game.

I am not going to keep creating websites for each souls game. This project while fulfilling, has taken up so much of my free time away from being actually able to play the game. This will be the first and last souls game website I create of this scale.

@75th
Copy link
Author

75th commented Aug 20, 2024

What is the problem that csv would be fixing in this case?

Some of my ideas would add properties to every single item in a list, and being able to import/export from a spreadsheet app would be much nicer than hand editing hundreds of JavaScript objects. I'm sure I can turn the JS objects into a CSV in the other direction somehow, but it seems to me that it'd be a more cut-and-dried process if they were more easily editable while at rest. Also it increases the chances of non-developers being able to contribute meaningfully.

This is the goal. I have the weapons I just need to sort them by how they appear in game. It's tough because they were given groups that don't exist in game iirc

Cool, I'll ignore that one for a bit if you think you'll get to it in the foreseeable future.

What's a sub group in armor? They are sorted currently by how they appear in game order. There is no sub groups in game only horizontal rules

The horizontal rules are exactly what I'm talking about. They group all the civilian clothes together, the mage robes together, soldier gear, knight gear, demigod gear, etc. Having those horizontal rules represented in the checklist would have been helpful to me while farming things to finish the checklist out on this playthrough.

I am not going to keep creating websites for each souls game. This project while fulfilling, has taken up so much of my free time away from being actually able to play the game. This will be the first and last souls game website I create of this scale.

Well, I haven't played past Souls games, but with any luck, the next game's checklist could be made by swapping new data into the current structure, with additional tweaks as needed. This is another advantage, too, to having data live in a more easily user-serviceable file format.

@Gobluebro
Copy link
Owner

Some of my ideas would add properties to every single item in a list, and being able to import/export from a spreadsheet app would be much nicer than hand editing hundreds of JavaScript objects. I'm sure I can turn the JS objects into a CSV in the other direction somehow, but it seems to me that it'd be a more cut-and-dried process if they were more easily editable while at rest. Also it increases the chances of non-developers being able to contribute meaningfully.

I don't think there is really a need for much more data. There are plenty of other projects already that do a lot of in depth things with the game and the spirit of this website is more about just keeping track of some stuff in game while you spend most of your time playing the game instead.

Feel free to fork the website and add anything you'd like or use this as a base for the next game.

The horizontal rules are exactly what I'm talking about.

I would probably look into maybe adding something in the list types that includes a separator and then it can be checked for and a horizontal rule can be added programmatically from the data. I have thought about the possibility of making them into separate checklists but I don't know what I'd name them.

@Gobluebro
Copy link
Owner

Gobluebro commented Aug 20, 2024

New list of Larval Tears with brief location descriptions
remembrance duplication coffins

These are fine, I believe the DLC has coffins without the wandering mausoleums so I'd just probably title it related to the coffins. I don't wish to add anything related to remembering what you copied.

Some understandable indication for each item when it has unique instances and/or is farmable

Specifically wanted to mention that I do not wish to add collectables that can be farmed. Collectibles should be limited to things that only be gotten once per playthrough

is missable vs. unmissable, etc.
marking missable Leyndell items after Maliketh's box is checked in the Bosses list.

I have wanted to add some sort of note feature like a little caption underneath a list item for a while to the point where I write notes in js comments for whenever I decided to add it in the future. So that would be a big help to implement

@Mobyh
Copy link

Mobyh commented Aug 22, 2024

Just wanted to add a suggestion for a feature. It'd be nice having a way to show/hide the base game stuff in the same way you can show/hide completed/DLC stuff

@Gobluebro
Copy link
Owner

Just wanted to add a suggestion for a feature. It'd be nice having a way to show/hide the base game stuff in the same way you can show/hide completed/DLC stuff

Apologies for the wait. This has been added in 695ec1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants