Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRToolsStaging: Should warn if no Fade is added as a child #629

Open
esodan opened this issue Apr 1, 2024 · 1 comment
Open

XRToolsStaging: Should warn if no Fade is added as a child #629

esodan opened this issue Apr 1, 2024 · 1 comment

Comments

@esodan
Copy link
Contributor

esodan commented Apr 1, 2024

XRToolsStaging should warn if no $Fade, a MeshInstance3D using a QuadMesh, hasn't been added as a child.

The warning should be shown and a new property fade hasn't been set by the user. Also, reference to $Face should be replaced with this new property

esodan added a commit to esodan/godot-xr-tools that referenced this issue Apr 1, 2024
XRToolsStaging requires a MeshInstance3D to hold a transition
fade. This adds a new property so the user is warned
to add this node to staging.

Fix issue GodotVR#629
@Malcolmnixon
Copy link
Collaborator

The script is intended to be used in conjunction with the provided staging.tscn scene file which includes the fade mesh. Instantiating it separately would require the developer to manually create many nodes - or for the script to programmatically construct those nodes.

Unfortunately Godot currently adds all named scripts to the "Add Child Node" wizard; making it difficult to prevent people from instantiating new nodes rather than the configured scenes.

esodan added a commit to esodan/godot-xr-tools that referenced this issue Apr 3, 2024
XRToolsStaging requires a MeshInstance3D to hold a transition
fade. This adds a new property so the user is warned
to add this node to staging.

Fix issue GodotVR#629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants